Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 6: (2 comments) Couple nits, then SGTM. http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_remote-test.cc File src/kudu/tools/ksck_remote-test.cc: http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_remote-test.cc@241 PS6, Line 241: $2 nit: Could you reorder the substitutions so $0 occurs as the first unique substitution, then $1, etc? http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_results.cc@301 PS6, Line 301: $1 Not your fault, but could you renumber these from $0 and remove the unused s.uuid argument? -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 14 May 2018 23:14:54 +0000 Gerrit-HasComments: Yes
