Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10293 )
Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10293/8/src/kudu/tools/ksck.cc@296 PS8, Line 296: ts->FetchInfo(&health).AndThen([&ts,&health]() { : if (FLAGS_consensus) { : return ts->FetchConsensusState(&h > Updated FetchConsensusState() to FetchConsensusState(&health), this felt mo Sound good. Mind adding it to the commit message as well? http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/10293/10/src/kudu/tools/ksck_remote.cc@209 PS10, Line 209: *health = KsckServerHealth::UNAVAILABLE; This never gets set to HEALTHY. I'm surprised that isn't caught somewhere by test; shouldn't that mean it will always result in an UNAVAILABLE ts in the report? Also, for symmetry, doc `health` in ksck.h and check for nullptr. -- To view, visit http://gerrit.cloudera.org:8080/10293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f Gerrit-Change-Number: 10293 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Wed, 16 May 2018 15:42:58 +0000 Gerrit-HasComments: Yes
