Attila Bukor has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10293 )

Change subject: KUDU-2426 Fix WRONG_SERVER_UUID case in ksck
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_remote-test.cc
File src/kudu/tools/ksck_remote-test.cc:

http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_remote-test.cc@241
PS6, Line 241: $0
> nit: Could you reorder the substitutions so $0 occurs as the first unique s
Done


http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_results.cc
File src/kudu/tools/ksck_results.cc:

http://gerrit.cloudera.org:8080/#/c/10293/6/src/kudu/tools/ksck_results.cc@301
PS6, Line 301: $0
> Not your fault, but could you renumber these from $0 and remove the unused
Done



--
To view, visit http://gerrit.cloudera.org:8080/10293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b4f50fe4dd94450b4f2e34dbad315bd761b071f
Gerrit-Change-Number: 10293
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Tue, 15 May 2018 10:35:43 +0000
Gerrit-HasComments: Yes

Reply via email to