Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/10332/7/src/kudu/util/curl_util.cc@96 PS7, Line 96: CHECK_NOTNULL(curl_headers); > nit: is this leftover debugging? Would curl_slist_append choke on a NULL cu Opps my bad. And that's not leftover debugging. Maybe curl_headers = CHECK_NOTNULL(curl_slist_append(curl_headers, header.c_str())); is better? And what do you mean the choking? -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 16 May 2018 16:04:26 +0000 Gerrit-HasComments: Yes
