Fengling Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10332 )
Change subject: KUDU-2035 Enable HTTP compression for all webserver's paths ...................................................................... Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG@9 PS6, Line 9: gzi > nit: Extra "the". Done http://gerrit.cloudera.org:8080/#/c/10332/6//COMMIT_MSG@10 PS6, Line 10: client > nit: I think the http terminology is "client" or "requestor". Done http://gerrit.cloudera.org:8080/#/c/10332/3/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/10332/3/src/kudu/server/webserver-test.cc@188 PS3, Line 188: Should > Nope, I think in that case it's better just to keep it consistent. Done http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@160 PS6, Line 160: deflate, br, gzip > Because I'm paranoid, could you put gzip second or later in the list, to te Done http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@183 PS6, Line 183: "Content-Type:"); > This is the status line; not a header. Also, neither this nor headers will Done http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver-test.cc@195 PS6, Line 195: compression > nit: Extra 's'. Done http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/server/webserver.cc@485 PS6, Line 485: ctor<string> encodings = strings::Spl > We have gutil functions to make this easier. Check out Thought about this but didn't search thoroughly. Thanks for reminding. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/util/curl_util.h@45 PS6, Line 45: e.g. > nit: I think 'e.g.' is more appropriate here because that's just an example Oh yes. Sorry it was a typo. http://gerrit.cloudera.org:8080/#/c/10332/6/src/kudu/util/curl_util.h@46 PS6, Line 46: Status FetchURL(const std::string& url, > warning: function 'kudu::EasyCurl::FetchURL' has a definition with differen Done http://gerrit.cloudera.org:8080/#/c/10332/3/src/kudu/util/curl_util.cc File src/kudu/util/curl_util.cc: http://gerrit.cloudera.org:8080/#/c/10332/3/src/kudu/util/curl_util.cc@90 PS3, Line 90: to cl > I meant curl_slist_append() returns nullptr if anything went wrong. I thin I see. -- To view, visit http://gerrit.cloudera.org:8080/10332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6db24b0fd2cbcca8a554460d310bd39ee5c071 Gerrit-Change-Number: 10332 Gerrit-PatchSet: 7 Gerrit-Owner: Fengling Wang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 15 May 2018 17:56:35 +0000 Gerrit-HasComments: Yes
