Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 )
Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10300/2/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10300/2/src/kudu/tools/ksck.cc@147 PS2, Line 147: s.ToString().find("Not authorized: unauthorized access to method") != string::npos; > I see. Would it make sense to still add EPERM/EACCES on the server side and I think we usually save the POSIX codes for statuses that result from syscalls. In any case, I really don't think it is worth it. -- To view, visit http://gerrit.cloudera.org:8080/10300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I644957103efefceeba4b82f4557376a603507423 Gerrit-Change-Number: 10300 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 19:06:22 +0000 Gerrit-HasComments: Yes
