Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10300 )
Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/ksck.cc@146 PS3, Line 146: s.IsRemoteError > OK, but there are also calls where a KuduClient would be used, and KuduClie Yeah, this lil helper is meant strictly for this specific ksck context. It is not meant to applicable anywhere else. http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/ksck_results.cc@171 PS3, Line 171: case KsckServerHealth::UNAUTHORIZED: : return 1; : case KsckServerHealth::UNAVAILABLE: : return 2; : case KsckServerHealth::WRONG_SERVER_UUID: > Maybe, that's just another reason to separate that different statuses like It's apples and oranges, ultimately, in that way. They are both apples in that they are the results of trying to fetch info from a tablet server as part of ksck. And as we need to sort things somehow, we have to pick some order. I think this one is reasonable for the reason I gave, but I agree yours is reasonable too. Consider which you'd want to notice and address first upon being given a ksck. http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/tool.proto File src/kudu/tools/tool.proto: http://gerrit.cloudera.org:8080/#/c/10300/3/src/kudu/tools/tool.proto@224 PS3, Line 224: UNAUTHORIZED = 3; > Yes, I know. My question was about whether it would be enough in that case The specifics errors are very useful for categorizing and sorting. They require different responses from the administrator. -- To view, visit http://gerrit.cloudera.org:8080/10300 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I644957103efefceeba4b82f4557376a603507423 Gerrit-Change-Number: 10300 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 25 May 2018 21:03:36 +0000 Gerrit-HasComments: Yes
