Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10300 )

Change subject: [tools] ksck imp. [8/n]: Easy-to-see errors when running w/o 
admin
......................................................................

[tools] ksck imp. [8/n]: Easy-to-see errors when running w/o admin

If ksck is not run as an admin user, then it cannot gather all of the
information it uses to do cluster checks. "Not authorized" errors are
easy to mistake for other errors. This patch handles these errors
specially to make it obvious to administrators when they have forgotten
to run as an administrative user.

The new errors at the end of the ksck output look like this:

==================
Errors:
==================
Not authorized: error fetching info from masters: failed to gather info from 1 
of 1 masters due to lack of admin privileges
Not authorized: error fetching info from tablet servers: failed to gather info 
from 11 of 12 tablet servers due to lack of admin privileges

FAILED
Not authorized: re-run ksck with administrator privileges

Change-Id: I644957103efefceeba4b82f4557376a603507423
Reviewed-on: http://gerrit.cloudera.org:8080/10300
Reviewed-by: Attila Bukor <[email protected]>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <[email protected]>
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/tool.proto
5 files changed, 77 insertions(+), 3 deletions(-)

Approvals:
  Attila Bukor: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/10300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I644957103efefceeba4b82f4557376a603507423
Gerrit-Change-Number: 10300
Gerrit-PatchSet: 6
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <[email protected]>

Reply via email to