Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 )
Change subject: [WIP] KUDU-2242 Wait for NTP synchronization on startup ...................................................................... Patch Set 1: (2 comments) looks good, just a couple nits http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc File src/kudu/clock/system_ntp.cc: http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@42 PS1, Line 42: DEFINE_uint32(ntp_initial_sync_wait_secs, 60, > Should probably tag this as advanced and evolving. nit: prefer signed integers per style guide http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@111 PS1, Line 111: n nit: single-letter variable not that useful -- To view, visit http://gerrit.cloudera.org:8080/10548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6082c5d35ed0d230d91c61734e7b5a351e50933b Gerrit-Change-Number: 10548 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 23:01:59 +0000 Gerrit-HasComments: Yes
