Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10548 )
Change subject: KUDU-2242 Wait for NTP synchronization on startup ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc File src/kudu/clock/system_ntp.cc: http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@42 PS1, Line 42: DEFINE_uint32(ntp_initial_sync_wait_secs, 60, > Should probably tag this as advanced and evolving. Done http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@42 PS1, Line 42: DEFINE_uint32(ntp_initial_sync_wait_secs, 60, > nit: prefer signed integers per style guide Done http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@111 PS1, Line 111: n > nit: single-letter variable not that useful Done http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@119 PS1, Line 119: Status s = FindExecutable("ntp-wait", {"/sbin", "/usr/sbin"}, &exe); > Why do we need to explicitly search in /sbin and /usr/sbin? Is it because t Honestly I was just mimicking what was done in TryRun, which looks for ntp and chrony utilities in this way, but I think sbin directories may sometimes be on the path only for superusers. http://gerrit.cloudera.org:8080/#/c/10548/1/src/kudu/clock/system_ntp.cc@121 PS1, Line 121: cmd = {exe, "-s", "1", "-n", std::to_string(n)}; > Could you doc the effects of these options? Done -- To view, visit http://gerrit.cloudera.org:8080/10548 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6082c5d35ed0d230d91c61734e7b5a351e50933b Gerrit-Change-Number: 10548 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 01 Jun 2018 18:29:09 +0000 Gerrit-HasComments: Yes
