Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10581 )
Change subject: KUDU-2191: Add 'kudu_only' flag ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h@339 PS1, Line 339: Status DeleteTable(const std::string& table_name, bool kudu_only = false); > I don't think adding a new parameter (even with a default) is ABI-compatibl KDE wiki's page on ABI compatibility [1] (linked from client/CMakeLists.txt) remains my go to resource. In this case "You cannot...For existing functions of any type: change its signature. This includes: extending a function with another parameter, even if this parameter has a default argument." Here's the suggested workaround. If you need to add extend/modify the parameter list of an existing function, you need to add a new function instead with the new parameters. In that case, you may want to add a short note that the two functions shall be merged with a default argument in later versions of the library: void functionname( int a ); void functionname( int a, int b ); //BCI: merge with int b = 0 1. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C++https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B -- To view, visit http://gerrit.cloudera.org:8080/10581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703f12b95bb7ca2d65455f0f0602520332b3c678 Gerrit-Change-Number: 10581 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 18:11:38 +0000 Gerrit-HasComments: Yes
