Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10581 )
Change subject: KUDU-2191: Add 'kudu_only' flag ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h@339 PS1, Line 339: Status DeleteTable(const std::string& table_name, bool kudu_only = false); > warning: function 'kudu::client::KuduClient::DeleteTable' has a definition I don't think adding a new parameter (even with a default) is ABI-compatible (here and below). Adar's the expert on this though -- To view, visit http://gerrit.cloudera.org:8080/10581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703f12b95bb7ca2d65455f0f0602520332b3c678 Gerrit-Change-Number: 10581 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 18:02:27 +0000 Gerrit-HasComments: Yes
