Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10581 )
Change subject: KUDU-2191: Add 'kudu_only' flag ...................................................................... Patch Set 1: (1 comment) > I don't think this flag should be exposed in public APIs because > it's not something many users will care about. What's the argument > for making it public? Makes sense, the only users for this change would be the HMS tools as what I can tell for now. So making it private instead. http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/10581/1/src/kudu/client/client.h@347 PS1, Line 347: KuduTableAlterer* NewTableAlterer(const std::string& table_name); > warning: function 'kudu::client::KuduClient::NewTableAlterer' has a definit Done -- To view, visit http://gerrit.cloudera.org:8080/10581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703f12b95bb7ca2d65455f0f0602520332b3c678 Gerrit-Change-Number: 10581 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 07 Jun 2018 07:21:25 +0000 Gerrit-HasComments: Yes
