Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 )
Change subject: KUDU-1861 add range-partitioning of loadgen tables ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10633/1/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/10633/1/src/kudu/tools/tool_action_perf.cc@605 PS1, Line 605: table_creator->set_range_partition_columns({ kKeyColumnName }); : for (int i = 1; i < FLAGS_table_num_buckets; i++) { : unique_ptr<KuduPartialRow> split(schema.NewRow()); : int64_t split_val = FLAGS_seq_start + i * span_per_tablet; : RETURN_NOT_OK(split->SetInt64(kKeyColumnName, split_val)); : > Does it work as intended in case of --table_num_buckets=1 ? It doesn't, but I don't think hash partitioning does either. I'll doc that somewhere. -- To view, visit http://gerrit.cloudera.org:8080/10633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f552a4c73dc82f3b7934082769522557ee5013 Gerrit-Change-Number: 10633 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 07 Jun 2018 14:54:02 +0000 Gerrit-HasComments: Yes
