Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 )
Change subject: KUDU-1861: add range-partitions to loadgen tables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10633/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/10633/3/src/kudu/tools/kudu-tool-test.cc@1460 PS3, Line 1460: TEST_F(ToolTest, TestLoadgenAutoGenTablePartitioning) { Can we test that the number of resulting tablets is what we'd expect each time? Also, could you add a test for a purely sequential insertion sequence that also looks at the bloom lookup metric value and tests that it's 0? http://gerrit.cloudera.org:8080/#/c/10633/3/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/10633/3/src/kudu/tools/tool_action_perf.cc@25 PS3, Line 25: // See below for examples of usage. Might want to update this with an example or two of partitioning. -- To view, visit http://gerrit.cloudera.org:8080/10633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f552a4c73dc82f3b7934082769522557ee5013 Gerrit-Change-Number: 10633 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 08 Jun 2018 03:32:08 +0000 Gerrit-HasComments: Yes
