Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10633 )
Change subject: KUDU-1861: add range-partitions to loadgen tables ...................................................................... Patch Set 3: (6 comments) Added a small test and verified the bloom lookups on a single tserver cluster again. http://gerrit.cloudera.org:8080/#/c/10633/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10633/2//COMMIT_MSG@10 PS2, Line 10: the loa > loadgen Done http://gerrit.cloudera.org:8080/#/c/10633/2//COMMIT_MSG@11 PS2, Line 11: the non-random write workload will insert sequentially on the primary > I think you're trying to see that the value of the _primary key_ will be mo Done http://gerrit.cloudera.org:8080/#/c/10633/2//COMMIT_MSG@48 PS2, Line 48: --table_num_range_partitions if desired. > Can you clarify why non-zero bloom lookups mean we're not inserting perfect Done http://gerrit.cloudera.org:8080/#/c/10633/2/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/10633/2/src/kudu/tools/tool_action_perf.cc@253 PS2, Line 253: "The number of range par > Nit: maybe "table_use_range_partitions"? Done http://gerrit.cloudera.org:8080/#/c/10633/2/src/kudu/tools/tool_action_perf.cc@405 PS2, Line 405: > I don't think this is used anymore. Done http://gerrit.cloudera.org:8080/#/c/10633/2/src/kudu/tools/tool_action_perf.cc@606 PS2, Line 606: const int64_t span_per_range = total_inserted_span / FLAGS_table_num_range_partitions; > So we're not going to use hash partitioning anymore if range partitions wer Done in the form of --table_num_range_partitions and --table_num_hash_partitions -- To view, visit http://gerrit.cloudera.org:8080/10633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4f552a4c73dc82f3b7934082769522557ee5013 Gerrit-Change-Number: 10633 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 08 Jun 2018 01:35:58 +0000 Gerrit-HasComments: Yes
