Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10693 )
Change subject: parse_metrics_log: update to the new format ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py File src/kudu/scripts/parse_metrics_log.py: http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@146 PS2, Line 146: # Iterate through all the entities for this metric. > seems somewhat unexpected for this function to have a side effect on its ar Done http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@147 PS2, Line 147: for eid in eid_to_vals: > "m not in cur" Done http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@163 PS2, Line 163: if metric_name in ret: > same Done http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@169 PS2, Line 169: def histogram_stats(aggregated_prev, aggregated_cur, m): > same comment about unexpected side effects Done -- To view, visit http://gerrit.cloudera.org:8080/10693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If11b7ecc93a3f64db3b7c1994f47308b3ec44029 Gerrit-Change-Number: 10693 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 21:23:42 +0000 Gerrit-HasComments: Yes
