Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10693 )
Change subject: parse_metrics_log: update to the new format ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10693/3/src/kudu/scripts/parse_metrics_log.py File src/kudu/scripts/parse_metrics_log.py: http://gerrit.cloudera.org:8080/#/c/10693/3/src/kudu/scripts/parse_metrics_log.py@123 PS3, Line 123: # Add the metric_id to the metrics map. you could use: ret = collections.defaultdict(dict) and it'll magically create empty dictionaries upon first reference, avoiding this if statement http://gerrit.cloudera.org:8080/#/c/10693/3/src/kudu/scripts/parse_metrics_log.py@276 PS3, Line 276: if not log_type == "metrics": nit: log_type != "metrics" -- To view, visit http://gerrit.cloudera.org:8080/10693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If11b7ecc93a3f64db3b7c1994f47308b3ec44029 Gerrit-Change-Number: 10693 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 22:16:40 +0000 Gerrit-HasComments: Yes
