Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10693 )
Change subject: parse_metrics_log: update to the new format ...................................................................... Patch Set 2: (4 comments) I guess the histogram-parsing code was "off" because now we only include buckets that have changed/are non-zero? Did you test it against some actual logs to make sure it has the expected results? Also, wondering if we should bite the bullet soon and port this to C++ so it runs faster and ships with kudu. http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py File src/kudu/scripts/parse_metrics_log.py: http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@146 PS2, Line 146: # Update the current metric in case we have missing entries. seems somewhat unexpected for this function to have a side effect on its arguments. Is there another spot we can put this, eg dpwn where we do the actual reading of the lines, we could shallow-copy the previous data and merge in the new data? http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@147 PS2, Line 147: if not m in cur: "m not in cur" http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@163 PS2, Line 163: if not m in prev: same http://gerrit.cloudera.org:8080/#/c/10693/2/src/kudu/scripts/parse_metrics_log.py@169 PS2, Line 169: cur[m] = prev[m] same comment about unexpected side effects -- To view, visit http://gerrit.cloudera.org:8080/10693 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If11b7ecc93a3f64db3b7c1994f47308b3ec44029 Gerrit-Change-Number: 10693 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 13 Jun 2018 00:11:26 +0000 Gerrit-HasComments: Yes
