Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10777 )
Change subject: KUDU-2260: Log block manager should handle null bytes in metadata on crash ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Would like for Mike to review and for Todd to read the answers you provided to his questions. http://gerrit.cloudera.org:8080/#/c/10777/3/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: http://gerrit.cloudera.org:8080/#/c/10777/3/src/kudu/util/pb_util.cc@317 PS3, Line 317: // See https://plus.google.com/+KentonVarda/posts/JDwHfAiLGNQ. : if (IsAllZeros(length_and_cksum_buf)) { > Linked. Is Ts'o well known enough you know his handle? :) Sadly (due to ext4 issues that we've chased), yes. -- To view, visit http://gerrit.cloudera.org:8080/10777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0af5c9dbbe28afe7a179595ad20392b99cde2a1b Gerrit-Change-Number: 10777 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Jun 2018 22:48:09 +0000 Gerrit-HasComments: Yes
