Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10777 )
Change subject: KUDU-2260: Log block manager should handle null bytes in metadata on crash ...................................................................... KUDU-2260: Log block manager should handle null bytes in metadata on crash On ext4 with data=ordered (the default), it's possible for a write to persist an increase to the filesize without persisting the actual data. In this case, the file will contain null bytes at the end. In the LBM, we considered this case to be corruption if there were enough null bytes (>= 8) for a PB container record length and length checksum. However, it's safe to call this an incomplete record and truncate the file at the end of the last complete record. This patch changes the P container reader code to return Status::Incomplete if it encounters this situation. This will cause the LBM to repair the container metadata appropriately. Two regression tests, at the PB container file and LBM layers, are included. Change-Id: I0af5c9dbbe28afe7a179595ad20392b99cde2a1b Reviewed-on: http://gerrit.cloudera.org:8080/10777 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/consensus/log_util.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/util/pb_util-test.cc M src/kudu/util/pb_util.cc M src/kudu/util/slice.cc M src/kudu/util/slice.h 6 files changed, 134 insertions(+), 51 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0af5c9dbbe28afe7a179595ad20392b99cde2a1b Gerrit-Change-Number: 10777 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
