Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10777 )
Change subject: KUDU-2260: Log block manager should handle null bytes in metadata on crash ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/pb_util.cc File src/kudu/util/pb_util.cc: http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/pb_util.cc@318 PS2, Line 318: if (IsAllZeros(length_and_cksum_buf)) { : bool all_zeros; > The discussion Mike linked in his comment on KUDU-2260 explains it in a rou aha, that is a very interesting thread. Thanks for the pointer, I learned something new today. http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/slice.h File src/kudu/util/slice.h: http://gerrit.cloudera.org:8080/#/c/10777/2/src/kudu/util/slice.h@302 PS2, Line 302: // test timeouts. This is only used on local buffers anyway, so we don't lose much > Do you mean you thought it would only get picked up on the definition? Oops, yea, I meant that I thought it had to be on the definition rather than the declaration. I'm surprised that the docs say it has to be on the declaration rather than definition. Guess I learned _two_ things today. -- To view, visit http://gerrit.cloudera.org:8080/10777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0af5c9dbbe28afe7a179595ad20392b99cde2a1b Gerrit-Change-Number: 10777 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 00:00:31 +0000 Gerrit-HasComments: Yes
