Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10588 )
Change subject: [tools] KUDU-2461 Add election metrics to ksck ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10588/4/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: http://gerrit.cloudera.org:8080/#/c/10588/4/src/kudu/consensus/metadata.proto@161 PS4, Line 161: // Number of failed elections and pre-elections since the last successful election : optional int64 failed_elections = 5; : : // Time in milliseconds since the last leader heartbeat : optional int64 millis_since_heartbeat = 6; > I don't think I feel good about shoving in these metrics with the cstate. T I think Will's idea about an RPC endpoint for metrics makes sense because it avoids having to pass the web UI port to ksck. -- To view, visit http://gerrit.cloudera.org:8080/10588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745 Gerrit-Change-Number: 10588 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 00:53:15 +0000 Gerrit-HasComments: Yes
