Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10588 )
Change subject: [tools] KUDU-2461 Add election metrics to ksck ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10588/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10588/4//COMMIT_MSG@24 PS4, Line 24: Config source | Replicas | Current term | Config index | Failed elections | Millis since heartbeat | Committed? didn't look at the patch yet, but this is starting to get really wide. Maybe we could abbreviate these columns a bit? eg just "term" instead of "current term", etc. Would be nice if it fit in 80-100 chars in the common case. Another thought: maybe we only show millis since heartbeat and failed elections if they are interesting (eg above some threshold like a few elections, or 15+sec heartbeat or something) -- To view, visit http://gerrit.cloudera.org:8080/10588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745 Gerrit-Change-Number: 10588 Gerrit-PatchSet: 4 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Jun 2018 17:38:11 +0000 Gerrit-HasComments: Yes
