Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10588 )
Change subject: [WIP] [tools] KUDU-2461 Add election metrics to ksck ...................................................................... Patch Set 5: tagged it as WIP as I think I should write tests for this, but before doing so, I wanted to ask if this is a good approach. Having an RPC to list all metrics seems like an overkill to me, so for now I implemented one for consensus metrics. Will, Todd, Mike, what do you think? -- To view, visit http://gerrit.cloudera.org:8080/10588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16fa6f32e6df7698365e908c7b48e63b0e52c745 Gerrit-Change-Number: 10588 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 22:24:37 +0000 Gerrit-HasComments: No
