Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10303 )
Change subject: KUDU-2191: HMS inconsistent metadata fix tool ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/10303/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10303/4//COMMIT_MSG@11 PS4, Line 11: And > And Done http://gerrit.cloudera.org:8080/#/c/10303/2/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10303/2/src/kudu/tools/tool_action_hms.cc@237 PS2, Line 237: > nit: present Done http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc@142 PS4, Line 142: install > 'Warn' Done http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc@448 PS4, Line 448: } > This is hard to follow, could the constraint instead be encoded in the type Done http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc@474 PS4, Line 474: > Picking an HMS entry to rename arbitrarily makes me pretty nervous, since H Discussed this offline, agreed it is not safe to automated fix for situation that there are multiple tables in the HMS sharing the same table ID. It would be better to have the admin manually fix it since the admin may have better idea of how to fix it. And this should be a very rare case to happen. For the case that the table in Kudu and the HMS have different names, we default it to the one in HMS since we consider HMS is the source of truth of table names. http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc@485 PS4, Line 485: TablesMap unsynced_tables_map; > Shouldn't this be a 'kudu only' alter? Yeah, AlterKuduTable() is only altering table in Kudu. Maybe I should rename it AlterKuduTableOnly() to be more clear. http://gerrit.cloudera.org:8080/#/c/10303/4/src/kudu/tools/tool_action_hms.cc@502 PS4, Line 502: > Why does this do a rename to the same table name? It is to trigger the correction of the master addr, column name, etc in the HMS. -- To view, visit http://gerrit.cloudera.org:8080/10303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 Gerrit-Change-Number: 10303 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Fri, 22 Jun 2018 01:29:37 +0000 Gerrit-HasComments: Yes
