Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10303 )
Change subject: KUDU-2191: HMS inconsistent metadata fix tool ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@404 PS7, Line 404: FilterUnsyncedTables(unsynced_tables_map); Perhaps the function should be called FilterOrphanedTables to make it more self documenting. http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@450 PS7, Line 450: shared_ptr<KuduTable> kudu_table = entry.second.first; Can kudu_table and hms_tables be const KuduTable& and const vector<hive::Table>& respectively? http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@483 PS7, Line 483: cout << Substitute("The table name in Kudu: $0 ", kudu_table_name) << endl; These would probably be simpler without the Substitute calls, e.g. cout << "The table name in Kudu: " << kudu_table_name << endl; http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@486 PS7, Line 486: cout << Substitute("Default to table name ($0) in the Hive Metastore.", "Default to..." isn't very descriptive of what is about to occur. I'd suggest something like "Renaming Kudu table foo.bar [id=abc123] to baz.quux to match the Hive Metastore catalog" http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@494 PS7, Line 494: cout << "Update master addresses property and column name and type " nit: "Updating metadata of table foo.bar [id=abc123] in the Hive Metastore catalog" -- To view, visit http://gerrit.cloudera.org:8080/10303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 Gerrit-Change-Number: 10303 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Jun 2018 17:11:26 +0000 Gerrit-HasComments: Yes
