Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/10303 )
Change subject: KUDU-2191: HMS inconsistent metadata fix tool ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@404 PS7, Line 404: FilterOrphanedTables(unsynced_tables_map); > Perhaps the function should be called FilterOrphanedTables to make it more Done http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@450 PS7, Line 450: const KuduTable& kudu_table = *entry.second.first; > Can kudu_table and hms_tables be const KuduTable& and const vector<hive::Ta Done http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@483 PS7, Line 483: cout << "The table name in Kudu: " << kudu_table_name << endl; > These would probably be simpler without the Substitute calls, e.g. Done http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@486 PS7, Line 486: cout << Substitute("Renaming Kudu table $0[id=$1] to $2 to match the Hive " > "Default to..." isn't very descriptive of what is about to occur. I'd sugg Done http://gerrit.cloudera.org:8080/#/c/10303/7/src/kudu/tools/tool_action_hms.cc@494 PS7, Line 494: // information in Kudu. > nit: "Updating metadata of table foo.bar [id=abc123] in the Hive Metastore Done -- To view, visit http://gerrit.cloudera.org:8080/10303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 Gerrit-Change-Number: 10303 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Jun 2018 20:39:29 +0000 Gerrit-HasComments: Yes
