Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: KUDU-2382 - [examples] Add Kudu Basic Python Example ...................................................................... Patch Set 1: (12 comments) Is there something used in the python world to specify dependencies and any build process? It'd be ideal if the basic example was self-contained, so if a user took the folder, copied it elsewhere, and started to use it as a basis for a Python application it'd be as easy as possible to get it running. http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@7 PS1, Line 7: KUDU-2382 - [examples] nit: [examples] KUDU-2382: ... http://gerrit.cloudera.org:8080/#/c/10794/1//COMMIT_MSG@10 PS1, Line 10: nit: is http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md File examples/python/basic-python-example/README.md: http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/README.md@2 PS1, Line 2: Licensed under the Apache License, Version 2.0 Why does this license header differ from our standard one? Because it's not source code? http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py File examples/python/basic-python-example/basic_example.py: http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@23 PS1, Line 23: kudu.master This needs to be configurable so the example is runnable. http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@25 PS1, Line 25: # Define a schema for a new table nit: End comments with a . here and below. http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@31 PS1, Line 31: nit: add "the" or "its" http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@34 PS1, Line 34: nit: a http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@51 PS1, Line 51: Updating nit: Update http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@59 PS1, Line 59: capture nit: extra word http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@62 PS1, Line 62: e Is there anything worth printing in this object? http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@69 PS1, Line 69: Scanner nit: scanner http://gerrit.cloudera.org:8080/#/c/10794/1/examples/python/basic-python-example/basic_example.py@71 PS1, Line 71: result = scanner.open().read_all_tuples() We should print and/or verify the results are as expected. -- To view, visit http://gerrit.cloudera.org:8080/10794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb Gerrit-Change-Number: 10794 Gerrit-PatchSet: 1 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 22 Jun 2018 15:29:47 +0000 Gerrit-HasComments: Yes
