Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md File examples/python/basic-python-example/README.md: http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@24 PS4, Line 24: > maybe mention somehow that this points to the lastest build which is normal Done http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@44 PS4, Line 44: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py File examples/python/basic-python-example/basic_example.py: http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py@18 PS4, Line 18: from datetime import datetime : import argparse : : import kudu > +1. Let's go further and pick an autoformatter. This makes sense, ill start this as a separate thread. I've modified the order of the ones in this example though. -- To view, visit http://gerrit.cloudera.org:8080/10794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb Gerrit-Change-Number: 10794 Gerrit-PatchSet: 5 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 26 Jun 2018 19:01:18 +0000 Gerrit-HasComments: Yes
