David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/10794 )
Change subject: [examples] KUDU-2382: Add Kudu Basic Python Example ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md File examples/python/basic-python-example/README.md: http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@24 PS4, Line 24: latest maybe mention somehow that this points to the lastest build which is normally debug? people wanting to test kudu out should probably use a release build http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/README.md@44 PS4, Line 44: nit: extra space http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py File examples/python/basic-python-example/basic_example.py: http://gerrit.cloudera.org:8080/#/c/10794/4/examples/python/basic-python-example/basic_example.py@18 PS4, Line 18: import kudu : from kudu.client import Partitioning : from datetime import datetime : import argparse aside: maybe we should start enforcing some import discipline? suggestion: <sys imports> <sys froms> <lib imports> <lib froms> <project imports> <project froms> It not at leas order these alphabetically and separate import from froms -- To view, visit http://gerrit.cloudera.org:8080/10794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12016a7c9b1f4a1e20556297654c7abfa7b673cb Gerrit-Change-Number: 10794 Gerrit-PatchSet: 4 Gerrit-Owner: Jordan Birdsell <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 25 Jun 2018 17:41:27 +0000 Gerrit-HasComments: Yes
