Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10303 )
Change subject: KUDU-2191: HMS inconsistent metadata fix tool ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/10303/8/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/10303/8/src/kudu/tools/tool_action_hms.cc@483 PS8, Line 483: cout << "The table name in Kudu: " << kudu_table_name << endl; : cout << "The database name, table name in the Hive Metastore: " : << hms_table_name << endl; Are these lines redundant with the 'Renaming...' message? http://gerrit.cloudera.org:8080/#/c/10303/8/src/kudu/tools/tool_action_hms.cc@486 PS8, Line 486: 0[id add a space between the table name and opening brace here and below. This format is somewhat standardized by the catalog manager. https://github.com/apache/kudu/blob/master/src/kudu/master/catalog_manager.cc#L4966-L4969 -- To view, visit http://gerrit.cloudera.org:8080/10303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I63c694b5d9877cfbd218139f2e9ecf05fd69c997 Gerrit-Change-Number: 10303 Gerrit-PatchSet: 8 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Tue, 26 Jun 2018 21:18:36 +0000 Gerrit-HasComments: Yes
