Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/common/schema.cc@140 PS6, Line 140: static const bool kFalse = false; Can you comment why the read default should be false? It's a little different than the usual case where a non-nullable column was added and historical values are being read. In this case, there are no values to read ever. http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/common/schema.cc@145 PS6, Line 145: &kFalse, Nit: Comment with /* read_default=*/ to match others. http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/common/schema.cc@154 PS6, Line 154: // TODO(adar): C++11 provides a single-arg constructor Nit: Do we assign individual names to given TODO's? I was under the impression we used Jiras or nothing. http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10968/6/src/kudu/master/catalog_manager.cc@1302 PS6, Line 1302: if (ContainsKey(Schema::kVirtualColumnNames, col_name)) { Would it be more future proof to prevent the $$ pattern in general? -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 19:50:37 +0000 Gerrit-HasComments: Yes
