Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 7: (1 comment) > I'm curious how this will plumb through all the way to the client. Have you > started working on any such patches for TabletService, etc? Not yet, no. http://gerrit.cloudera.org:8080/#/c/10968/7/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/10968/7/src/kudu/master/catalog_manager.cc@1302 PS7, Line 1302: if (ContainsKey(Schema::kVirtualColumnNames, col_name)) { > Instead of the set, maybe we should just reserve all identifiers of the for Yeah, Grant had the same feedback. I'm open to making that change; just wanted to make sure this is headed in the right direction first (see my back and forth with Dan). -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 22:57:41 +0000 Gerrit-HasComments: Yes
