Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 )
Change subject: [tablet] clean-up on replay of WAL entries ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11032/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11032/1//COMMIT_MSG@9 PS1, Line 9: Reduced number of memory allocations while reading WAL entries from : disk during tablet bootstrap. > which memory allocation was reduced? I'm having a hard time finding the fun Before the patch there was an extra call to 'new LogEntryPB' in TabletBootstrap::PlaySegments(). Now it's gone. The purpose of this changelist is not to improve performance, but rather simplify passing LogEntryPB ownership around. -- To view, visit http://gerrit.cloudera.org:8080/11032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39516b09e4c756e8af1d8e1a5604672c96a80cb Gerrit-Change-Number: 11032 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 24 Jul 2018 18:13:33 +0000 Gerrit-HasComments: Yes
