Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11032 )
Change subject: [tablet] clean-up on replay of WAL entries ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11032/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11032/1//COMMIT_MSG@9 PS1, Line 9: Reduced number of memory allocations while reading WAL entries from : disk during tablet bootstrap. which memory allocation was reduced? I'm having a hard time finding the functional change among the scoped_ptr-related changes. It seems like if we really wanted to improve performance here we would allow LogEntryPBs to be recycled -- ie instead of freeing an entry, we would pass it back into the LogReader to be reused when reading the next entry. This would keep us from having to continually free and reallocate the relatively large strings that usually end up inside LogEntryPB, and I think provide a measurable boost. Does this change get us closer to that or farther away? Or make no difference in that respect? -- To view, visit http://gerrit.cloudera.org:8080/11032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie39516b09e4c756e8af1d8e1a5604672c96a80cb Gerrit-Change-Number: 11032 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 24 Jul 2018 15:58:09 +0000 Gerrit-HasComments: Yes
