Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@158 PS11, Line 158: static bool IsVirtual() { : return false; : } nit: maybe, move this into the DataTypeTraits template itself and have custom specialization just for IS_DELETED? http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@673 PS11, Line 673: case IS_DELETED: nit: add FALLTHROUGH_INTENDED ? http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@763 PS11, Line 763: case IS_DELETED: nit: add FALLTHROUGH_INTENDED ? http://gerrit.cloudera.org:8080/#/c/10968/10/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/10968/10/src/kudu/common/types.h@625 PS10, Line 625: return DataTypeTraits<BOOL>::name(); > It was at first, but that led to a row dump that looked like this: But if it's name is 'bool', then how to distinguish between a column of virtual type and regular bool in a row dump? Or we don't need to differentiate between those in row dumps? >From the other side, what if the new type was named 'VIRTULAL_BOOL' or >'VBOOL' instead of 'IS_DELETED'? -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 11 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 14:30:54 +0000 Gerrit-HasComments: Yes
