Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10968 )
Change subject: schema: add is_deleted virtual column ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/10968/11/src/kudu/common/types.h@673 PS11, Line 673: case IS_DELETED: > nit: add FALLTHROUGH_INTENDED ? In my opinion this isn't an appropriate use for FALLTHRUGH_INTENDED. It should only be used when a case contains an statement, and then after evaluating that statement falls into another case. The docs on FALLTHROUGH_INTENDED show this: // switch (x) { // case 40: // case 41: // if (truth_is_out_there) { // ++x; // FALLTHROUGH_INTENDED; // Use instead of/along with annotations in // // comments. // } else { // return x; // } // case 42: // ... Notice how there is no FALLTHROUGH_INTENDED annotation for the (statement-less) case 40. -- To view, visit http://gerrit.cloudera.org:8080/10968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56eb1d44ba8bfbd76d8bb794b8076b695782939e Gerrit-Change-Number: 10968 Gerrit-PatchSet: 12 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 18:50:48 +0000 Gerrit-HasComments: Yes
