Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: Enable TSAN and LSAN supressions in Java dist-tests ...................................................................... Patch Set 2: > I think there is actually some way to link in options into the program itself > by providing some weak symbol which returns a string, maybe we should > consider that? Here's the ASAN method of doing that: https://github.com/google/sanitizers/wiki/AddressSanitizerFlags#run-time-flags Not sure if UBSAN or TSAN support it. Agreed that centralizing this somewhere is better than sprinkling it in build-and-test.sh, run-test.sh, the dist-test scripts, and elsewhere. According to https://github.com/google/sanitizers/wiki/SanitizerCommonFlags we could stash each sanitizer's options in a file, then the only "sprinkling" we'll need is the single option include="..." (to tell the sanitizer where the option file is). -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 09 Aug 2018 18:54:15 +0000 Gerrit-HasComments: No
