Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: WIP: Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11176/4/src/kudu/sanitizers/sanitizer_options.cc File src/kudu/sanitizers/sanitizer_options.cc: http://gerrit.cloudera.org:8080/#/c/11176/4/src/kudu/sanitizers/sanitizer_options.cc@27 PS4, Line 27: __attribute__((no_sanitize("address", "memory", "thread", "undefined"))) \ do we need to do a no_xray_instrument or something too? http://gerrit.cloudera.org:8080/#/c/11176/4/src/kudu/sanitizers/sanitizer_options.cc@37 PS4, Line 37: const char* kAsanDefaultOptions = "strip_path_prefix=/../ "; nit: should probably be const char* const http://gerrit.cloudera.org:8080/#/c/11176/4/src/kudu/sanitizers/sanitizer_options.cc@57 PS4, Line 57: return kTsanDefaultOptions; if the user specifies their own TSAN_OPTIONS do they get merged with these defaults? ie is it still possible for users to override things as we suggest in various dev-facing docs? -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 09 Aug 2018 21:51:58 +0000 Gerrit-HasComments: Yes
