Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11176 )
Change subject: [build] Move default sanitizer options into build from shell scripts ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/11176/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11176/6//COMMIT_MSG@9 PS6, Line 9: supressions suppressions http://gerrit.cloudera.org:8080/#/c/11176/6/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11176/6/src/kudu/util/CMakeLists.txt@327 PS6, Line 327: kudu_sanitizer_options) Nit: should precede kudu_util. http://gerrit.cloudera.org:8080/#/c/11176/6/src/kudu/util/sanitizer_options.cc File src/kudu/util/sanitizer_options.cc: http://gerrit.cloudera.org:8080/#/c/11176/6/src/kudu/util/sanitizer_options.cc@35 PS6, Line 35: return kAsanDefaultOptions; Nit: could we inline kAsanDefaultOptions directly into the return statement? As is you have to follow from the variable definition to the return statement in __asan_default_options; inlining would eliminate that following. Same for the other options/suppressions below. -- To view, visit http://gerrit.cloudera.org:8080/11176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9eab2d3ef0b107ae9a4e971bf8a6514bf425f645 Gerrit-Change-Number: 11176 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 22:28:06 +0000 Gerrit-HasComments: Yes
