Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@9 PS2, Line 9: - Add build and thirdparty to exclude list in Jekyll front matter, : because if switching between master and gh-pages, these remain there and : breaking the builds. doesn't make this change less useful, but maybe 'git worktree' would be helpful for you if you didn't know about it already http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13 PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on : MacOS. The dependencies were updated manually to make sure it still : works on Ruby 1.9.3 on Linux as well. maybe we should move this to a Dockerfile soon so that jekyll runs inside docker in a consistent environment? -- To view, visit http://gerrit.cloudera.org:8080/11210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217 Gerrit-Change-Number: 11210 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 18:55:21 +0000 Gerrit-HasComments: Yes
