Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11210 )
Change subject: [site] Fix site building ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11210/2//COMMIT_MSG@13 PS2, Line 13: - Update a few dependencies in Gemfile.lock so it works with Ruby 2.5 on : MacOS. The dependencies were updated manually to make sure it still : works on Ruby 1.9.3 on Linux as well. > Good idea, although this fix is still useful I think as a docker container I'd hope that if we moved to docker we would only support that as the one true way to build docs/site. That way we can freely upgrade our dependencies on jekyll/ruby/whatever without having to worry that it works on every platform. Agreed it doesn't need to block this commit though, was just suggesting it as a way to avoid future pain. -- To view, visit http://gerrit.cloudera.org:8080/11210 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I61cb8a6f6fae5423c3e7a123954ce21bc3c03217 Gerrit-Change-Number: 11210 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 22:09:58 +0000 Gerrit-HasComments: Yes
