Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11259 )
Change subject: KUDU-2531: (part 1) Ignore backup files ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/fs/fs_manager.cc@625 PS1, Line 625: // Return true if 'fname' is a valid tablet ID. Any idea why we don't implement this by verifying that the filename is a 32 character hexadecimal sequence? Not sure why we need all these special cases. http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/util/env_util.cc File src/kudu/util/env_util.cc: http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/util/env_util.cc@312 PS1, Line 312: iter->find(kTmpInfix) != string::npos || : iter->find(kBakInfix) != string::npos) { Both of these exceptions feel really strange to me. These are real files; why would we ignore them in a ListFiles function? -- To view, visit http://gerrit.cloudera.org:8080/11259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f0e6dd8925519aa3ed3e735f2987743f2ef1d1 Gerrit-Change-Number: 11259 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 17 Aug 2018 21:07:15 +0000 Gerrit-HasComments: Yes
