Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11259 )
Change subject: KUDU-2531: (part 1) Ignore invalid tablet metadata files ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11259/4/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/11259/4/src/kudu/fs/fs_manager.cc@633 PS4, Line 633: ObjectIdGenerator oid_generator; Creating a new one of these for every call seems wasteful when we can have thousands of tablets. Can you store one in the FsManager itself? -- To view, visit http://gerrit.cloudera.org:8080/11259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f0e6dd8925519aa3ed3e735f2987743f2ef1d1 Gerrit-Change-Number: 11259 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Mon, 20 Aug 2018 19:36:30 +0000 Gerrit-HasComments: Yes
