Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11259 )
Change subject: KUDU-2531: (part 1) Ignore backup files ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11259/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11259/2//COMMIT_MSG@9 PS2, Line 9: Backup files may be left behind by tools and will prevent the server from starting. This patch ensures files with a .bak extension are ignored. nit: can you break this into shorter lines? http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: http://gerrit.cloudera.org:8080/#/c/11259/1/src/kudu/fs/fs_manager.cc@625 PS1, Line 625: // Return true if 'fname' is a valid tablet ID. > Any idea why we don't implement this by verifying that the filename is a 32 yeah, I agree it would be a better approach -- To view, visit http://gerrit.cloudera.org:8080/11259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9f0e6dd8925519aa3ed3e735f2987743f2ef1d1 Gerrit-Change-Number: 11259 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Sat, 18 Aug 2018 14:07:47 +0000 Gerrit-HasComments: Yes
