Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11115 )
Change subject: [location_awareness] Assign locations to registering tablet servers ...................................................................... Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11115/7/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11115/7/src/kudu/master/ts_descriptor.cc@231 PS7, Line 231: string location; : TRACE("Assigning location"); : Status s = GetLocationFromLocationMappingCmd(location_ma > In order to implement a timeout, we ought to run the location assignment in Yes, I think it's not worth complicating this unless there is an urgency in doing so. Maybe, it's worth adding a metric to count failed runs of the location assignment command, but otherwise I think it's possible to track that in the master's log. http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc@62 PS9, Line 62: nit: it seems this flag is now run-time. Maybe, it's worth reflecting that information in here. -- To view, visit http://gerrit.cloudera.org:8080/11115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eb98823ab7b3b8141b8630196c29c1ebf8e6878 Gerrit-Change-Number: 11115 Gerrit-PatchSet: 9 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:34:22 +0000 Gerrit-HasComments: Yes
