Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11115 )
Change subject: [location_awareness] Assign locations to registering tablet servers ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc@62 PS9, Line 62: > To me, a runtime flag means one it's ok to change at runtime and that we ar As I can see, de facto all run-time flags in Kudu have that race condition, but it's not a bit deal. But we could use thread-safe gflags::GetCommandLineOption(), if needed, since GenericServiceImpl::SetFlag() uses gflags::SetCommandLineOption() which is thread-safe: https://github.com/gflags/gflags/blob/master/src/gflags.h.in#L206 However, if you think it's not worth it, that's OK with me. -- To view, visit http://gerrit.cloudera.org:8080/11115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eb98823ab7b3b8141b8630196c29c1ebf8e6878 Gerrit-Change-Number: 11115 Gerrit-PatchSet: 9 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 05 Sep 2018 00:54:52 +0000 Gerrit-HasComments: Yes
