Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11115 )
Change subject: [location_awareness] Assign locations to registering tablet servers ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/11115/9/src/kudu/master/ts_descriptor.cc@62 PS9, Line 62: > nit: it seems this flag is now run-time. Maybe, it's worth reflecting that To me, a runtime flag means one it's ok to change at runtime and that we are blessing as ok to change. I don't want users to change the flag at runtime, and in fact I think we'd have a data race between changing the flag and its value being used to assign a location. -- To view, visit http://gerrit.cloudera.org:8080/11115 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5eb98823ab7b3b8141b8630196c29c1ebf8e6878 Gerrit-Change-Number: 11115 Gerrit-PatchSet: 10 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 04 Sep 2018 21:50:53 +0000 Gerrit-HasComments: Yes
