Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11411
Change subject: [WIP] Add helper macro for tool invocations ...................................................................... [WIP] Add helper macro for tool invocations Using `ASSERT_OK` to test the results of the `kudu` tool is normal, but it results in lousy test failure output: ../../src/kudu/tools/kudu-admin-test.cc:235: Failure Failed Bad status: Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1 This adds a new macro, `ASSERT_TOOL_OK`, that also logs the stdout and stderr of a `kudu` tool invocation: ../../src/kudu/tools/kudu-admin-test.cc:235: Failure Failed Runtime error: /Users/wdberkeley/src/kudu/build/debug/bin/kudu: process exited with non-zero status 1 stdout: stderr: W0910 12:39:07.483736 2830984064 flags.cc:406] Enabled unsafe flag: --never_fsync=true Invalid argument: Unrecognized peer type: FOOVOTER WIP because the macro is a little clunky and I'd like input from wiser C++ people. Once the macro is finalized. there are a lot more places to update to use the new macro. Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07 --- M src/kudu/tools/kudu-admin-test.cc 1 file changed, 31 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/11411/1 -- To view, visit http://gerrit.cloudera.org:8080/11411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7ffd357d79982ee5c93f8d3c7cfd7cc1f0863f07 Gerrit-Change-Number: 11411 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]>
